thakis added a comment. In D91913#2520503 <https://reviews.llvm.org/D91913#2520503>, @hvdijk wrote:
> In D91913#2520432 <https://reviews.llvm.org/D91913#2520432>, @zequanwu wrote: > >> In D91913#2520414 <https://reviews.llvm.org/D91913#2520414>, @hvdijk wrote: >> >>> In D91913#2520399 <https://reviews.llvm.org/D91913#2520399>, @zequanwu >>> wrote: >>> >>>> This change also breaks many chrome ToT bots(not just windows bot), >>>> example build: >>>> https://ci.chromium.org/ui/p/chrome/builders/ci/ToTLinuxOfficial/10524/steps?succeeded=true&debug=false >>> >>> That requires an account to see. >> >> This should be accessible without an account: >> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8857139118288337920/+/steps/compile/0/stdout > > Indeed. However, here, this seems to be a user problem. Chrome `-std=c++*` > when building with clang, but `-std=gnu++*` when building with GCC for > exactly this reason, see build/config/compiler/BUILD.gn. Chrome should use > `-std=gnu++*` with clang too. We (and every other project out there) needs some incremental rollout plan for this. We don't want to allow _more_ GNU features. Please put this behind a `-f` toggle, or revert this for a bit implementing this takes some time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
