tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
In D93638#2483913 <https://reviews.llvm.org/D93638#2483913>, @hliao wrote: > Forget that C function could be overloaded on Clang with overloadable > extension. With that, we don't need to mark functions from `<ymath.h>` as HD. > Instead, we could provide their device-side implementation directly. Ah. It was the "C" part that I was missing. I was only thinking of C++/HIP/CUDA. I think we're on the same page now. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
