abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments.
================ Comment at: clang/lib/Lex/LiteralSupport.cpp:234 + SmallString<8> ResultCharConv; + Converter->convert(std::string(1, ByteChar), ResultCharConv); + memcpy((void *)&ResultChar, ResultCharConv.data(), sizeof(unsigned)); ---------------- tahonermann wrote: > Conversion can fail here, particularly in the scenario corresponding to the > default switch case above; `ResultChar` could contain, for example, a lead > byte of a UTF-8 sequence. Something sensible should be done here; either > rejecting the code with an error or substituting `?` (in the execution > encoding) seems appropriate to me. Thanks, I added the substitution with the '?' character for invalid escapes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D93031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
