curdeius added a comment.
This LGTM in general. I just have a doubt.
You've added `messUp` parameter to `verifyFormat`, because, IIUC, pragmas
wouldn't be at the desired scope level indentation otherwise.
Shouldn't clang-format find out what the correct indentation level for pragmas
should be instead of keeping the current indentation (when IndentPragmas: true)?
Correct me if my understanding is wrong.
Anyway, my point is that turning off messUp seems like a bad idea and may hide
some problems, nope?
What would be the output of:
void foo() {
#pragma omp
for (...) {
#pragma omp
for (...) {
}
}
}
Do the `#pragma`s get intended to the level of corresponding `for`s or not?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92753/new/
https://reviews.llvm.org/D92753
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
