lebedev.ri added a comment. In D92257#2437918 <https://reviews.llvm.org/D92257#2437918>, @HazardyKnusperkeks wrote:
> In D92257#2435906 <https://reviews.llvm.org/D92257#2435906>, @lebedev.ri > wrote: > >> In D92257#2435902 <https://reviews.llvm.org/D92257#2435902>, @MyDeveloperDay >> wrote: >> >>> In D92257#2435899 <https://reviews.llvm.org/D92257#2435899>, >>> @HazardyKnusperkeks wrote: >>> >>>> In D92257#2435701 <https://reviews.llvm.org/D92257#2435701>, >>>> @MyDeveloperDay wrote: >>>> >>>>> Can I assume you need someone to land this for you? >>>> >>>> Yes I do. But I have a question, my last change is commited in your name, >>>> that means git blame would blame it on you, right? >>>> >>>> You can set me as author: >>>> `Björn Schäpers <bjo...@hazardy.de>` >>>> My Github Account is also called `HazardyKnusperkeks`. >>> >>> The process is that you add (https://llvm.org/docs/Contributing.html) >>> >>> Patch By: HazardyKnusperkeks >>> >>> to the commit message if the user doesn't have commit access, if you want >>> your name against the blame then I recommend applying for commit access >>> yourself. >> >> That is incorrect and does not represent the nowadays reality, i suggest >> that you look up the docs. >> >>> let me know if you still want me to land this > > What/Where are the docs? I read https://llvm.org/docs/Contributing.html > before hand and just now https://llvm.org/docs/CodeReview.html My comment was addressed at @MyDeveloperDay https://llvm.org/docs/DeveloperPolicy.html#commit-messages If you’re not the original author, ensure the ‘Author’ property of the commit is set to the original author and the ‘Committer’ property is set to yourself. You can use a command similar to git commit --amend --author="John Doe <j...@llvm.org>" to correct the author property if it is incorrect. See Attribution of Changes for more information including the method we used for attribution before the project migrated to git. IOW @HazardyKnusperkeks's request was correct. > --- > > I will update the patch, but that won't happen before the weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.org/D92257 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
