MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3718 + } else + DwarfFission = DwarfFissionKind::None; ---------------- dblaikie wrote: > Rather than undoing the DwarfFission uinitialization, instead could the > DwarfFission initialization be rolled into the "if (gN_Group)" condition? I could add the OPT_g_Group check to `getDebugFissionKind`, but that would make the effects of -g0 and "no -g at all" into two places. Having the code here makes it closer to "how DebugInfoKind == codegenoptions::NoDebugInfo affects fission" above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
