dblaikie added a comment. In D80391#2438447 <https://reviews.llvm.org/D80391#2438447>, @MaskRay wrote:
> In D80391#2437926 <https://reviews.llvm.org/D80391#2437926>, @dblaikie wrote: > >> Looks like GCC has changed the semantics here despite the backwards >> compatibility break - as much as I'd rather not break backwards >> compatibility it's probably best on balance to maintain GCC compatibility >> instead: https://godbolt.org/z/zGanxE >> >> Could you either provide in this patch or a follow-up, a -gno-split-dwarf >> flag? (probabyl better in a follow-up) > > Sounds good. Will add -gno-split-dwarf Great, thanks! >> Could you check that this is compatible with the cmake split DWARF support >> in the LLVM build system, and with Google's internal use, before committing? >> (not sure there are any other users of this feature we can effectively >> update - or that I specifically know of) > > Will do! I can test whether ("-gsplit-dwarf" -> "-gsplit-dwarf -g") exposes > any issue. The new `-gsplit-dwarf` should be equivalent to the old > `-gsplit-dwarf -g` Yeah, likely what would be suitable would be to add the -g to both those use cases before committing the change in behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
