tra added inline comments.

================
Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:22
+// Make sure we do not see any dwarf version other than 2, regardless of 
what's used on the host side.
+// CHECK-NOT: {{-dwarf-version=[^2]}}
 // CHECK: "-triple" "x86_64
----------------
MaskRay wrote:
> A NOT pattern may easily become stale and do not actually check anything. 
> Just turn to a positive pattern?
In this case the issue is with the CHECK-NOT line above. I'll have to replicate 
it around the positive match of `-dwarf-version` which would raise more 
questions.

I wish filecheck would allow to `mark` a region and then run multiple matches 
on it, instead of re-anchoring on each match. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92617/new/

https://reviews.llvm.org/D92617

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to