tra added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3857 + auto AdjustedDwarfVersion = TC.GetAdjustedDwarfVersion(DWARFVersion); + ---------------- dblaikie wrote: > I worry a bit about having both DWARFVersion and AdjustedDwarfVersion in this > scope (I'd worry about some codepaths using one when they needed to use the > other, etc) - if at all possible, would be good to just override DWARFVersion > with the adjusted value. And probably could/should be up in the "EmitDwarf" > block above that's handling default dwarf versions and overrides of it? Ive updated the implementation to make it less ambiguous. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https://reviews.llvm.org/D92617 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
