craig.topper added a comment. In D90822#2375425 <https://reviews.llvm.org/D90822#2375425>, @pengfei wrote:
> In D90822#2375423 <https://reviews.llvm.org/D90822#2375423>, @pengfei wrote: > >> Craig's method sounds good. > > I think it may result in potential problem once we change the order of them > in immintrin.h, it should be better to use the first method. > > #if !(defined(_MSC_VER) || defined(SCE)) || __has_feature(modules) || \ > (defined(__AVX512VL__) && define(__AVX512BW__)) But if the order changes then the code won't compile because _m512i or some other type won't be defined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
