craig.topper added inline comments.

================
Comment at: clang/lib/Headers/gfniintrin.h:23
 
+#ifdef __AVX__
+#ifdef __AVX512BW__
----------------
This needs to be more like

#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||      
\                                                                               
                              
    (defined(__AVXVL__)  && define(__AVX512BW__))


We want all intrinsics to be defined for when not compiling for MSVC 
compatibility. Otherwise using attribute(target) doesn't work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90822/new/

https://reviews.llvm.org/D90822

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to