alexfh accepted this revision.
alexfh added a comment.

In D89886#2347376 <https://reviews.llvm.org/D89886#2347376>, @DmitryPolukhin 
wrote:

> In D89886#2346851 <https://reviews.llvm.org/D89886#2346851>, @alexfh wrote:
>
>> Ah, btw, any chance of adding a test for this?
>
> Oh, I was not able to create small reproducer that without including large 
> Apple Frameworks with modules :( My hypothesis that it is side effect of 
> module cache that triggers module load before it is referenced from sources. 
> I tested it on reproducer from PR47839 + my real internal example.

I see. Let's keep it as is then.

Looks good!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89886/new/

https://reviews.llvm.org/D89886

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to