alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
Looks good! ================ Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:27 + // detection. + if (!File->getName().endswith("module.modulemap")) + FilesToRecord.insert(File); ---------------- Looking at the relevant code I find special file names like "module.map", "module_private.map", "module.private.modulemap". Is this problem relevant for any of those? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89886/new/ https://reviews.llvm.org/D89886 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits