Conanap added inline comments.
================ Comment at: clang/lib/Headers/altivec.h:17394 +static __inline__ vector signed __int128 __ATTRS_o_ai +vec_mod(vector signed __int128 __a, vector signed __int128 __b) { + return __builtin_altivec_vmodsq(__a, __b); ---------------- Conanap wrote: > amyk wrote: > > nit: Move these under the existing `vec_mod` builtins. > > Also, is it possible for these to be open coded instead? We have `vec_mod` > > for other types that are open coded. > > > Probably? Although the downsteram impementation is actually not open coded. > We can still change it though. > Probably? Although the downsteram impementation is actually not open coded. > We can still change it though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87394/new/ https://reviews.llvm.org/D87394 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits