hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land.
LGTM from my end; although @MaskRay might want another look. ================ Comment at: clang/lib/Basic/Targets/OSTargets.h:758 + Builder.defineMacro("__DLL__"); + // XOPEN_SOURCE=600 is required to build libcxx. + Builder.defineMacro("_XOPEN_SOURCE", "600"); ---------------- Minor nit: s/XOPEN_SOURCE/_XOPEN_SOURCE/; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85324/new/ https://reviews.llvm.org/D85324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits