hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:736
+ MacroBuilder &Builder) const override {
+ // FIXME: LONG_LONG should not be defined under -std=c89
+ Builder.defineMacro("_LONG_LONG");
----------------
Minor nit: Typo.
The FIXME is okay until there's a reason to fix this. The review necessary for
addressing the FIXME deserves another patch anyway.
The situation between z/OS and AIX is different for this case. On AIX, the C
ABI compatibility of `imaxdiv_t` is affected. In other words, on AIX, fixing
this might cause surprising behaviour.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:743
+ Builder.defineMacro("__BFP__");
+ Builder.defineMacro("__BOOL__");
+ Builder.defineMacro("__LONGNAME__");
----------------
Sorry for not catching this earlier, but this also needs a FIXME re: strict C89.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85324/new/
https://reviews.llvm.org/D85324
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
