steakhal added a comment. In D86223#2228731 <https://reviews.llvm.org/D86223#2228731>, @xazax.hun wrote:
> In D86223#2227353 <https://reviews.llvm.org/D86223#2227353>, @steakhal wrote: > >> Eh, I'm not sure if it worth it to put these into virtual functions - as >> conditionally overriding functions is not really a good idea. > > I am not sure I follow. What do you mean by conditionally overriding? What is > the condition? I wanted to conditionally, aka. in debug configuration override the base implementation of the SymbolData::getKindStr to print return the specific kind string. In any other configuration I wanted to indef out the overriding functions to let the SymbolData implementation to be triggered. In that way less macro expansion would have been necessary, resulting in cleaner code. Unfortunately I would have needed even more macros to make the subtype override function declarations disappear. This was the reason that I suggested to leave the current implementation as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86223/new/ https://reviews.llvm.org/D86223 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
