steakhal added a comment. In D86223#2226876 <https://reviews.llvm.org/D86223#2226876>, @xazax.hun wrote:
> Exactly, but you could return a StringRef to static storage. > > I am fine with both approach. Whichever you find cleaner. Eh, I'm not sure if it worth it to put these into virtual functions - as conditionally overriding functions is not really a good idea. So we would not win much. I still think that this way is the cleanest AFAIK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86223/new/ https://reviews.llvm.org/D86223 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
