dblaikie added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642
+    int Num;
+    if (V == "future")
+      A->render(Args, CmdArgs);
----------------
ro wrote:
> MaskRay wrote:
> > phosek wrote:
> > > Another option would be `unstable`.
> > I picked `future` because there is an precedent: `-mcpu=future` is used by 
> > some ppc folks.
> I fear that's a terrible precedent: this name had to be chosen because for 
> some unknown, but certainly silly, reason, IBM didn't wan't to call it 
> `power10` before release.
A little more respect for other developers would be great here - hard to know 
it's silly if you don't know the reason & even if you think it is silly, folks 
may not have the same goals/requirements you do.

(that's not to dismiss the concern that the precedent for naming -mcpu may not 
apply as well here (not suggesting it doesn't either - I have no opinion either 
way))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85474/new/

https://reviews.llvm.org/D85474

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to