phosek added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642
+ int Num;
+ if (V == "future")
+ A->render(Args, CmdArgs);
----------------
Another option would be `unstable`.
================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:738
- if (!getContext().getAsmInfo()->useIntegratedAssembler()) {
- // If we are not using the integrated assembler then this symbol might have
+ if (!getContext().getAsmInfo()->useIntegratedASOrGAS(2, 35)) {
+ // If we are using GNU as before 2.35, then this symbol might have
----------------
I'd prefer to spell it out in full, i.e.
`getContext().getAsmInfo()->useIntegratedAssembler() ||
!getContext().getAsmInfo()->binutilsVersion(2, 35)`, it's more verbose but it's
cleaner to me what it does just when looking at this line alone.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85474/new/
https://reviews.llvm.org/D85474
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
