alexfh added inline comments.

================
Comment at: 
docs/clang-tidy/checks/readability-static-definition-in-anonymous-namespace.rst:9
@@ +8,3 @@
+In this case, `static` is redundant, because anonymous namespace limits the
+visibility of definitions to a single translation unit.
+
----------------
This is still not done.

================
Comment at: 
test/clang-tidy/readability-static-definition-in-anonymous-namespace.cpp:34
@@ +33,3 @@
+#define DEFINE_STATIC_VAR(x) static int x = 2
+DEFINE_STATIC_VAR(i);
+// CHECK-FIXES: {{^}}DEFINE_STATIC_VAR(i);
----------------
hokein wrote:
> Oops. I misunderstood your comment. Done now.
Sorry for being unclear again: please add

  // CHECK-FIXES: #define DEFINE_STATIC_VAR(x) static int x = 2

to verify that the check doesn't unintentionally remove `static` from the macro 
definition. Same for the macro above.


http://reviews.llvm.org/D18180



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to