Rob added a comment.

ok, I'm not sure if its worth rolling back the change to 
modernize-use-override-ms.cpp, see ammended comments above.

Apart from this it should be good to go.

I think I am going to need someone to submit the patch for me, I can't use svn 
due to 'error 400' so I've been using the git mirror.


================
Comment at: test/clang-tidy/modernize-use-override-ms.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s modernize-use-override %t
+
----------------
alexfh wrote:
> Does this test pass on linux? If no additional compiler arguments needed and 
> it just works, maybe just merge this test code to the main test file?
That's a good question.  I have been running it with the additional 
-fms-extensions argument, but on windows I find it works with or without that 
option.  I havent tested it on linux.  I could maybe rummage up a virtual 
machine and give it a go.




http://reviews.llvm.org/D18396



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to