alexfh added a comment. In http://reviews.llvm.org/D18396#388287, @Rob wrote:
> I tried > > check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override > temp -- -- -fms-extensions It also needs -std=c++11, which needs to be specified, when you specify any options manually. > and > > check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override > temp > > on OSX and nethier work as expected. > > So instead I have changed the test to use visibility attributes when _MSC_VER > is not defined. ... which means that the code is not tested on non-windows platforms, though it could be. > Also updated the release notes. Thanks! ================ Comment at: test/clang-tidy/modernize-use-override-ms.cpp:1 @@ +1,2 @@ +// RUN: %check_clang_tidy %s modernize-use-override %t + ---------------- aaron.ballman wrote: > I *think* this run line may require -fms-extensions in order to compile under > non-MSVC-built versions of clang because of the __declspec. I've just tried this on Linux and it actually needs `-fms-extensions` (actually, you'll need to append `-- -- -std=c++11 -fms-extensions`). http://reviews.llvm.org/D18396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
