ABataev added inline comments.
================
Comment at: clang/lib/Parse/ParseExpr.cpp:1933
}
+ if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) {
+ // Consume ':'
----------------
cchen wrote:
> cchen wrote:
> > ABataev wrote:
> > > Seems to me, it is too broad. According to the standard, it must be
> > > allowed only in to/from clauses.
> > I did the check in Sema, I'll move the check here. Thanks
> We didn't pass OpenMP clause information here. Do you think I should put the
> analysis in ParseOpenMPVarList or put the check in SemaOpenMP?
Try to pass it somehow. Maybe, create a parser data member with the current
kind of the clause we trying to parse?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82800/new/
https://reviews.llvm.org/D82800
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
