ABataev added inline comments.
================
Comment at: clang/lib/Parse/ParseExpr.cpp:1928-1930
if (Tok.isNot(tok::r_square))
- Length = ParseExpression();
+ if (getLangOpts().OpenMP < 50 ||
+ ((Tok.isNot(tok::colon) && getLangOpts().OpenMP >= 50)))
----------------
Better merge into one logical expression.
================
Comment at: clang/lib/Parse/ParseExpr.cpp:1933-1934
}
+ if (getLangOpts().OpenMP >= 50)
+ if (Tok.is(tok::colon)) {
+ // Consume ':'
----------------
Same, better to merge into one condition.
================
Comment at: clang/lib/Sema/TreeTransform.h:10344
+ ExprResult Stride;
+ if (E->getStride()) {
+ Stride = getDerived().TransformExpr(E->getStride());
----------------
Better to make it this way:
```
if (Expr *Str = E->getStride()) {
Stride = getDerived().TransformExpr(Str);
...
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82800/new/
https://reviews.llvm.org/D82800
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
