aaron.ballman added inline comments.
================
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:124
+llvm::Optional<llvm::Regex::RegexFlags> getRegexFlag(llvm::StringRef Flag) {
+ for (auto &StringFlag : RegexMap) {
+ if (Flag == StringFlag.first)
----------------
`const auto &` (same below)
================
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:158
+ }
+ if (!Any)
+ return None; // Without this an empty string would return "NoFlags",
----------------
I would probably simplify this (untested):
```
SmallVector<StringRef, 4> Split;
llvm::Optional<llvm::Regex::RegexFlags> Flag;
Flags.split(Split, '|', -1, false);
for (StringRef OrFlag : Split) {
if (llvm::Optional<llvm::Regex::RegexFlags> NextFlag =
getRegexFlag(OrFlag.trim())) {
Flag = Flag.getValueOr(llvm::Regex::NoFlags) | *NextFlag;
}
}
return Flag;
```
Similar below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82706/new/
https://reviews.llvm.org/D82706
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
