uweigand added a comment.

I don't think we actually need the builtins-systemz-z13.c test, it only 
duplicates tests already done by builtins-systemz.c and 
builtins-systemz-vector.c.  (Note that those tests implicitly verify that there 
is no compiler error by checking the compiler exit code.)

Also, you should be able to combine the two -generic tests into a single one 
(the compiler doesn't abort at errors, so you can check for multiple errors 
with a single -verify run).  Maybe the combined test should be named 
builtins-systemz-error.c ?

LGTM with those changes.


http://reviews.llvm.org/D17142



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to