SouraVX accepted this revision. SouraVX added a comment. This revision is now accepted and ready to land.
In D82470#2118814 <https://reviews.llvm.org/D82470#2118814>, @jdoerfert wrote: > In D82470#2116581 <https://reviews.llvm.org/D82470#2116581>, @SouraVX wrote: > > > Overall this seems great Thanks! I have one minor concern: > > This patch seems to do 2 things: Support for nested parallel regions(which > > was crashing earlier) and some infrastructure change(introducing > > AllocBuilder..). > > I'm not sure of this, but is it possible to separate these as 2( or more) > > patches ? 1 for Nested parallel region support and other patch as a > > infrastructure change ? > > > I'll try. Thanks a lot for separating this :) both LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
