jdoerfert updated this revision to Diff 273961.
jdoerfert edited the summary of this revision.
jdoerfert added a comment.
restrict this to the alloca support
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82470/new/
https://reviews.llvm.org/D82470
Files:
llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
Index: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
===================================================================
--- llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
+++ llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
@@ -6,13 +6,14 @@
//
//===----------------------------------------------------------------------===//
+#include "llvm/Frontend/OpenMP/OMPConstants.h"
#include "llvm/Frontend/OpenMP/OMPIRBuilder.h"
#include "llvm/IR/BasicBlock.h"
#include "llvm/IR/DIBuilder.h"
#include "llvm/IR/Function.h"
+#include "llvm/IR/InstIterator.h"
#include "llvm/IR/LLVMContext.h"
#include "llvm/IR/Module.h"
-#include "llvm/Frontend/OpenMP/OMPConstants.h"
#include "llvm/IR/Verifier.h"
#include "llvm/Transforms/Utils/BasicBlockUtils.h"
#include "gtest/gtest.h"
@@ -402,6 +403,201 @@
EXPECT_EQ(ForkCI->getArgOperand(3), F->arg_begin());
}
+TEST_F(OpenMPIRBuilderTest, ParallelNested) {
+ using InsertPointTy = OpenMPIRBuilder::InsertPointTy;
+ OpenMPIRBuilder OMPBuilder(*M);
+ OMPBuilder.initialize();
+ F->setName("func");
+ IRBuilder<> Builder(BB);
+
+ OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP(), DL});
+
+ unsigned NumInnerBodiesGenerated = 0;
+ unsigned NumOuterBodiesGenerated = 0;
+ unsigned NumFinalizationPoints = 0;
+
+ auto InnerBodyGenCB = [&](InsertPointTy AllocaIP, InsertPointTy CodeGenIP,
+ BasicBlock &ContinuationIP) {
+ ++NumInnerBodiesGenerated;
+ };
+
+ auto PrivCB = [&](InsertPointTy AllocaIP, InsertPointTy CodeGenIP,
+ Value &VPtr, Value *&ReplacementValue) -> InsertPointTy {
+ // Trivial copy (=firstprivate).
+ Builder.restoreIP(AllocaIP);
+ Type *VTy = VPtr.getType()->getPointerElementType();
+ Value *V = Builder.CreateLoad(VTy, &VPtr, VPtr.getName() + ".reload");
+ ReplacementValue = Builder.CreateAlloca(VTy, 0, VPtr.getName() + ".copy");
+ Builder.restoreIP(CodeGenIP);
+ Builder.CreateStore(V, ReplacementValue);
+ return CodeGenIP;
+ };
+
+ auto FiniCB = [&](InsertPointTy CodeGenIP) { ++NumFinalizationPoints; };
+
+ auto OuterBodyGenCB = [&](InsertPointTy AllocaIP, InsertPointTy CodeGenIP,
+ BasicBlock &ContinuationIP) {
+ ++NumOuterBodiesGenerated;
+ Builder.restoreIP(CodeGenIP);
+ BasicBlock *CGBB = CodeGenIP.getBlock();
+ BasicBlock *NewBB = SplitBlock(CGBB, &*CodeGenIP.getPoint());
+ CGBB->getTerminator()->eraseFromParent();
+ ;
+
+ IRBuilder<>::InsertPoint AfterIP = OMPBuilder.CreateParallel(
+ InsertPointTy(CGBB, CGBB->end()), InnerBodyGenCB, PrivCB, FiniCB,
+ nullptr, nullptr, OMP_PROC_BIND_default, false);
+
+ Builder.restoreIP(AfterIP);
+ Builder.CreateBr(NewBB);
+ };
+
+ IRBuilder<>::InsertPoint AfterIP =
+ OMPBuilder.CreateParallel(Loc, OuterBodyGenCB, PrivCB, FiniCB, nullptr,
+ nullptr, OMP_PROC_BIND_default, false);
+
+ EXPECT_EQ(NumInnerBodiesGenerated, 1U);
+ EXPECT_EQ(NumOuterBodiesGenerated, 1U);
+ EXPECT_EQ(NumFinalizationPoints, 2U);
+
+ Builder.restoreIP(AfterIP);
+ Builder.CreateRetVoid();
+
+ OMPBuilder.finalize();
+
+ EXPECT_EQ(M->size(), 5U);
+ for (Function &OutlinedFn : *M) {
+ if (F == &OutlinedFn || OutlinedFn.isDeclaration())
+ continue;
+ EXPECT_FALSE(verifyModule(*M, &errs()));
+ EXPECT_TRUE(OutlinedFn.hasFnAttribute(Attribute::NoUnwind));
+ EXPECT_TRUE(OutlinedFn.hasFnAttribute(Attribute::NoRecurse));
+ EXPECT_TRUE(OutlinedFn.hasParamAttribute(0, Attribute::NoAlias));
+ EXPECT_TRUE(OutlinedFn.hasParamAttribute(1, Attribute::NoAlias));
+
+ EXPECT_TRUE(OutlinedFn.hasInternalLinkage());
+ EXPECT_EQ(OutlinedFn.arg_size(), 2U);
+
+ EXPECT_EQ(OutlinedFn.getNumUses(), 1U);
+ User *Usr = OutlinedFn.user_back();
+ ASSERT_TRUE(isa<ConstantExpr>(Usr));
+ CallInst *ForkCI = dyn_cast<CallInst>(Usr->user_back());
+ ASSERT_NE(ForkCI, nullptr);
+
+ EXPECT_EQ(ForkCI->getCalledFunction()->getName(), "__kmpc_fork_call");
+ EXPECT_EQ(ForkCI->getNumArgOperands(), 3U);
+ EXPECT_TRUE(isa<GlobalVariable>(ForkCI->getArgOperand(0)));
+ EXPECT_EQ(ForkCI->getArgOperand(1),
+ ConstantInt::get(Type::getInt32Ty(Ctx), 0U));
+ EXPECT_EQ(ForkCI->getArgOperand(2), Usr);
+ }
+}
+
+TEST_F(OpenMPIRBuilderTest, ParallelNested2Inner) {
+ using InsertPointTy = OpenMPIRBuilder::InsertPointTy;
+ OpenMPIRBuilder OMPBuilder(*M);
+ OMPBuilder.initialize();
+ F->setName("func");
+ IRBuilder<> Builder(BB);
+
+ OpenMPIRBuilder::LocationDescription Loc({Builder.saveIP(), DL});
+
+ unsigned NumInnerBodiesGenerated = 0;
+ unsigned NumOuterBodiesGenerated = 0;
+ unsigned NumFinalizationPoints = 0;
+
+ auto InnerBodyGenCB = [&](InsertPointTy AllocaIP, InsertPointTy CodeGenIP,
+ BasicBlock &ContinuationIP) {
+ ++NumInnerBodiesGenerated;
+ };
+
+ auto PrivCB = [&](InsertPointTy AllocaIP, InsertPointTy CodeGenIP,
+ Value &VPtr, Value *&ReplacementValue) -> InsertPointTy {
+ // Trivial copy (=firstprivate).
+ Builder.restoreIP(AllocaIP);
+ Type *VTy = VPtr.getType()->getPointerElementType();
+ Value *V = Builder.CreateLoad(VTy, &VPtr, VPtr.getName() + ".reload");
+ ReplacementValue = Builder.CreateAlloca(VTy, 0, VPtr.getName() + ".copy");
+ Builder.restoreIP(CodeGenIP);
+ Builder.CreateStore(V, ReplacementValue);
+ return CodeGenIP;
+ };
+
+ auto FiniCB = [&](InsertPointTy CodeGenIP) { ++NumFinalizationPoints; };
+
+ auto OuterBodyGenCB = [&](InsertPointTy AllocaIP, InsertPointTy CodeGenIP,
+ BasicBlock &ContinuationIP) {
+ ++NumOuterBodiesGenerated;
+ Builder.restoreIP(CodeGenIP);
+ BasicBlock *CGBB = CodeGenIP.getBlock();
+ BasicBlock *NewBB1 = SplitBlock(CGBB, &*CodeGenIP.getPoint());
+ BasicBlock *NewBB2 = SplitBlock(NewBB1, &*NewBB1->getFirstInsertionPt());
+ CGBB->getTerminator()->eraseFromParent();
+ ;
+ NewBB1->getTerminator()->eraseFromParent();
+ ;
+
+ IRBuilder<>::InsertPoint AfterIP1 = OMPBuilder.CreateParallel(
+ InsertPointTy(CGBB, CGBB->end()), InnerBodyGenCB, PrivCB, FiniCB,
+ nullptr, nullptr, OMP_PROC_BIND_default, false);
+
+ Builder.restoreIP(AfterIP1);
+ Builder.CreateBr(NewBB1);
+
+ IRBuilder<>::InsertPoint AfterIP2 = OMPBuilder.CreateParallel(
+ InsertPointTy(NewBB1, NewBB1->end()), InnerBodyGenCB, PrivCB, FiniCB,
+ nullptr, nullptr, OMP_PROC_BIND_default, false);
+
+ Builder.restoreIP(AfterIP2);
+ Builder.CreateBr(NewBB2);
+ };
+
+ IRBuilder<>::InsertPoint AfterIP =
+ OMPBuilder.CreateParallel(Loc, OuterBodyGenCB, PrivCB, FiniCB, nullptr,
+ nullptr, OMP_PROC_BIND_default, false);
+
+ EXPECT_EQ(NumInnerBodiesGenerated, 2U);
+ EXPECT_EQ(NumOuterBodiesGenerated, 1U);
+ EXPECT_EQ(NumFinalizationPoints, 3U);
+
+ Builder.restoreIP(AfterIP);
+ Builder.CreateRetVoid();
+
+ OMPBuilder.finalize();
+
+ EXPECT_EQ(M->size(), 6U);
+ for (Function &OutlinedFn : *M) {
+ if (F == &OutlinedFn || OutlinedFn.isDeclaration())
+ continue;
+ EXPECT_FALSE(verifyModule(*M, &errs()));
+ EXPECT_TRUE(OutlinedFn.hasFnAttribute(Attribute::NoUnwind));
+ EXPECT_TRUE(OutlinedFn.hasFnAttribute(Attribute::NoRecurse));
+ EXPECT_TRUE(OutlinedFn.hasParamAttribute(0, Attribute::NoAlias));
+ EXPECT_TRUE(OutlinedFn.hasParamAttribute(1, Attribute::NoAlias));
+
+ EXPECT_TRUE(OutlinedFn.hasInternalLinkage());
+ EXPECT_EQ(OutlinedFn.arg_size(), 2U);
+
+ unsigned NumAllocas = 0;
+ for (Instruction &I : instructions(OutlinedFn))
+ NumAllocas += isa<AllocaInst>(I);
+ EXPECT_EQ(NumAllocas, 1U);
+
+ EXPECT_EQ(OutlinedFn.getNumUses(), 1U);
+ User *Usr = OutlinedFn.user_back();
+ ASSERT_TRUE(isa<ConstantExpr>(Usr));
+ CallInst *ForkCI = dyn_cast<CallInst>(Usr->user_back());
+ ASSERT_NE(ForkCI, nullptr);
+
+ EXPECT_EQ(ForkCI->getCalledFunction()->getName(), "__kmpc_fork_call");
+ EXPECT_EQ(ForkCI->getNumArgOperands(), 3U);
+ EXPECT_TRUE(isa<GlobalVariable>(ForkCI->getArgOperand(0)));
+ EXPECT_EQ(ForkCI->getArgOperand(1),
+ ConstantInt::get(Type::getInt32Ty(Ctx), 0U));
+ EXPECT_EQ(ForkCI->getArgOperand(2), Usr);
+ }
+}
+
TEST_F(OpenMPIRBuilderTest, ParallelIfCond) {
using InsertPointTy = OpenMPIRBuilder::InsertPointTy;
OpenMPIRBuilder OMPBuilder(*M);
Index: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
===================================================================
--- llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -430,17 +430,32 @@
// we want to delete at the end.
SmallVector<Instruction *, 4> ToBeDeleted;
- Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI());
- AllocaInst *TIDAddr = Builder.CreateAlloca(Int32, nullptr, "tid.addr");
- AllocaInst *ZeroAddr = Builder.CreateAlloca(Int32, nullptr, "zero.addr");
+ // The alloca builder is managed internally basically like a stack. The
+ // insertion point guards keep the old top value alive while we update it for
+ // the body.
+ //
+ // TODO: We now have an internal AllocaBuilder and the AllocaIP in the
+ // callback, one might suffice.
+ IRBuilder<>::InsertPointGuard AIPG(AllocaBuilder);
+
+ // For the first outermost region we need to initialize the alloca builder.
+ if (!AllocaBuilder.GetInsertBlock())
+ AllocaBuilder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI());
+
+ // Use the debug location of the pragma for alloca related code as well.
+ AllocaBuilder.SetCurrentDebugLocation(Loc.DL);
+
+ AllocaInst *TIDAddr = AllocaBuilder.CreateAlloca(Int32, nullptr, "tid.addr");
+ AllocaInst *ZeroAddr =
+ AllocaBuilder.CreateAlloca(Int32, nullptr, "zero.addr");
// If there is an if condition we actually use the TIDAddr and ZeroAddr in the
// program, otherwise we only need them for modeling purposes to get the
// associated arguments in the outlined function. In the former case,
// initialize the allocas properly, in the latter case, delete them later.
if (IfCondition) {
- Builder.CreateStore(Constant::getNullValue(Int32), TIDAddr);
- Builder.CreateStore(Constant::getNullValue(Int32), ZeroAddr);
+ AllocaBuilder.CreateStore(Constant::getNullValue(Int32), TIDAddr);
+ AllocaBuilder.CreateStore(Constant::getNullValue(Int32), ZeroAddr);
} else {
ToBeDeleted.push_back(TIDAddr);
ToBeDeleted.push_back(ZeroAddr);
@@ -484,14 +499,14 @@
// of the outlined function.
InsertPointTy AllocaIP(PRegEntryBB,
PRegEntryBB->getTerminator()->getIterator());
- Builder.restoreIP(AllocaIP);
+ AllocaBuilder.restoreIP(AllocaIP);
AllocaInst *PrivTIDAddr =
- Builder.CreateAlloca(Int32, nullptr, "tid.addr.local");
- Instruction *PrivTID = Builder.CreateLoad(PrivTIDAddr, "tid");
+ AllocaBuilder.CreateAlloca(Int32, nullptr, "tid.addr.local");
+ Instruction *PrivTID = AllocaBuilder.CreateLoad(PrivTIDAddr, "tid");
// Add some fake uses for OpenMP provided arguments.
- ToBeDeleted.push_back(Builder.CreateLoad(TIDAddr, "tid.addr.use"));
- ToBeDeleted.push_back(Builder.CreateLoad(ZeroAddr, "zero.addr.use"));
+ ToBeDeleted.push_back(AllocaBuilder.CreateLoad(TIDAddr, "tid.addr.use"));
+ ToBeDeleted.push_back(AllocaBuilder.CreateLoad(ZeroAddr, "zero.addr.use"));
// ThenBB
// |
@@ -690,6 +705,10 @@
LLVM_DEBUG(dbgs() << "Captured input: " << *Input << "\n");
PrivHelper(*Input);
}
+ LLVM_DEBUG({
+ for (Value *Output : Outputs)
+ LLVM_DEBUG(dbgs() << "Captured output: " << *Output << "\n");
+ });
assert(Outputs.empty() &&
"OpenMP outlining should not produce live-out values!");
Index: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
===================================================================
--- llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
+++ llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
@@ -28,7 +28,8 @@
public:
/// Create a new OpenMPIRBuilder operating on the given module \p M. This will
/// not have an effect on \p M (see initialize).
- OpenMPIRBuilder(Module &M) : M(M), Builder(M.getContext()) {}
+ OpenMPIRBuilder(Module &M)
+ : M(M), Builder(M.getContext()), AllocaBuilder(M.getContext()) {}
/// Initialize the internal state, this will put structures types and
/// potentially other helpers into the underlying module. Must be called
@@ -276,6 +277,9 @@
/// The LLVM-IR Builder used to create IR.
IRBuilder<> Builder;
+ /// The LLVM-IR Builder used to create alloca instructions.
+ IRBuilder<> AllocaBuilder;
+
/// Map to remember source location strings
StringMap<Constant *> SrcLocStrMap;
@@ -285,7 +289,6 @@
/// Helper that contains information about regions we need to outline
/// during finalization.
struct OutlineInfo {
- SmallVector<BasicBlock *, 32> Blocks;
using PostOutlineCBTy = std::function<void(Function &)>;
PostOutlineCBTy PostOutlineCB;
BasicBlock *EntryBB, *ExitBB;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
