kadircet added inline comments.
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
- Builder.AddPlaceholderChunk("qualifier");
- Builder.AddTextChunk("::");
----------------
lh123 wrote:
> lh123 wrote:
> > kadircet wrote:
> > > unfortunately the reasoning above doesn't apply here, as a using
> > > declaration *must* have a nested-name-specifier. e.g. `using X;` is not
> > > allowed. so please revert this (and following on `using typename` it
> > > requires a nested-name-specifier too)
> > Yes, you are right. but I think complete `using` as `using qualifier::name`
> > is not useful when user want input something like `using A = B`.
> I think we just need revert change for `using typename qualifier::name`. WDYT.
right but using declarations vs aliases are two different use cases, I would
suggest adding a separate completion item for that in form:
`using $alias$ = $type$;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82373/new/
https://reviews.llvm.org/D82373
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
