MaskRay marked 6 inline comments as done.
MaskRay added inline comments.
================
Comment at: clang/docs/ClangCommandLineReference.rst:891
Restrict sanitizer coverage instrumentation exclusively to modules and
functions that match the provided special case list, except the blacklisted ones
----------------
echristo wrote:
> I'd remove the uses of blacklist and whitelist here and below. Just have the
> language and the documentation be for the new option.
`clang-tblgen -gen-opt-docs` does not seem to provide a feature to hide an
option. HelpHidden does not hide the option.
================
Comment at: clang/docs/SanitizerCoverage.rst:435
Options
- -blacklist=<string> - Blacklist file (sanitizer blacklist
format).
+ -blacklist=<string> - Blocklist file (sanitizer blocklist
format).
-demangle - Print demangled function name.
----------------
echristo wrote:
> blacklist here.
sancov is another tool that is not touched by this patch. It should be updated
separately.
================
Comment at: clang/include/clang/Driver/Options.td:1002
HelpText<"Restrict sanitizer coverage instrumentation exclusively to
modules and functions that match the provided special case list, except the
blacklisted ones">;
-def fsanitize_coverage_blacklist : Joined<["-"],
"fsanitize-coverage-blacklist=">,
+def : Joined<["-"], "fsanitize-coverage-whitelist=">,
+ Group<f_clang_Group>, Flags<[CoreOption, HelpHidden]>,
Alias<fsanitize_coverage_allowlist>;
----------------
echristo wrote:
> Deprecate the option and comment it as such.
HelpHidden will hide the options from help.
================
Comment at:
compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_allowlist_blocklist.cpp:2
+// Tests -fsanitize-coverage-allowlist=whitelist.txt and
+// -fsanitize-coverage-blocklist=blacklist.txt with libFuzzer-like coverage
// options
----------------
echristo wrote:
> blacklist filename. probably want to change wl_* and bl_* below as well.
wl_ -> al_
bl_ can still mean blocklist.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82244/new/
https://reviews.llvm.org/D82244
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
