kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/TestFS.h:36 public: - // Prevent name hiding caused by the overload below. - using FileSystemProvider::getFileSystem; - IntrusiveRefCntPtr<llvm::vfs::FileSystem> getFileSystem() const { return buildTestFS(Files, Timestamps); ---------------- sammccall wrote: > this looks out of place - should it be inlined or renamed? i thought this had a ton of usage in our tests, apparently that's not the case. changed those usages to `view(llvm::None)` instead and inlined this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits