NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Ok, this simplification is obviously correct. I don't mind landing it regardless of the crash. If it gets rid of the crash, even better. I'm still worried about the root cause of the crash though. I recommend to add an assertion into `CStringChecker::assumeZero()` that's equivalent to whatever assertion was previously crashing, and continue debugging from there to see if it uncovers more bugs in the checker. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
