clementval added a comment. In D81736#2096336 <https://reviews.llvm.org/D81736#2096336>, @jdoerfert wrote:
> In D81736#2095947 <https://reviews.llvm.org/D81736#2095947>, @clementval > wrote: > > > In D81736#2093926 <https://reviews.llvm.org/D81736#2093926>, @jdoerfert > > wrote: > > > > > Assuming this passes all the tests, it looks good to me. Let's wait a day > > > or two for people to take a look though :) > > > > > > @jdoerfert Sure let's wait a bit. I see a failure because of some > > clang-tidy warnings. How strongly should I fix them? I see some conflict > > with other code I see in TableGen. > > > Clang-tidy run by Phab is not binding but if it's reasonable modify it. Keep > the TableGen style consistent. @jdoerfert I made some fix to fit in the TableGen style. So this is ready to land on my side. I'm working on the next patches. One that replace the specific enums in Flang to use the one defined here. Another one that continue to replace the MACROS in OMPConstants.h/.cpp with TableGen code generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/ https://reviews.llvm.org/D81736 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
