clementval added a comment. In D81736#2093926 <https://reviews.llvm.org/D81736#2093926>, @jdoerfert wrote:
> Assuming this passes all the tests, it looks good to me. Let's wait a day or > two for people to take a look though :) @jdoerfert Sure let's wait a bit. I see a failure because of some clang-tidy warnings. How strongly should I fix them? I see some conflict with other code I see in TableGen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/ https://reviews.llvm.org/D81736 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits