hubert.reinterpretcast added inline comments.
================ Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4482 + llvm::Value *NeedsDestruct = + CGF.Builder.CreateIsNull(V, "needsDestruct"); + ---------------- There are uses of `CreateIsNull` with `snake_case`; this is the only `camelCase` instance. ================ Comment at: clang/test/CodeGen/static-init.cpp:14 + } t1, t2; +}; // namespace test1 ---------------- Minor nit: Don't use a semicolon after a namespace definition. Apply throughout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
