hubert.reinterpretcast added inline comments.
================ Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:807 void CodeGenFunction::GenerateCXXGlobalDtorsFunc( llvm::Function *Fn, ---------------- This function is to be renamed. ================ Comment at: clang/lib/CodeGen/CodeGenModule.h:401 + /// A unique trailing identifier as a part of sinit/sterm function when + /// UseSinitAndSterm of CXXABI set as true. + std::string GlobalUniqueModuleId; ---------------- Minor nit: s/set/is set/; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits