thakis added a comment.

We don't store physical absolute paths in pdbs if you hold things right. Look 
for /pdbsourcepath: in 
http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html . 
rnk's change seems to store the main TU's dir as cwd, which likely either takes 
the dir from the main TU as passed (ie if you pass an erlative path, it stores 
that), or it honors /pdbsourcepath:. If that's fine as-is, that's ok. It's 
different from what `pwd` returns though I think. (imagine you're in c:\foo and 
you build bar\baz.cc. the cwd in the pdb will be c:\foo\bar but the command 
will be relative to c:\foo if I understand things right? I might not though.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80833/new/

https://reviews.llvm.org/D80833



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to