amccarth accepted this revision.
amccarth added a comment.
My only real concern was about the possible reproducibility impact of
introducing absolute paths into the binaries. If @thakis and @hans are
satisfied this is OK, then LGTM.
================
Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:8
+// CHECK: ============================================================
+// CHECK: 0x[[PWD:.+]] | LF_STRING_ID [size = {{.+}}] ID: <no type>, String:
[[PWDVAL:.+]]
+// CHECK: 0x[[FILEPATH:.+]] | LF_STRING_ID [size = {{.+}}] ID: <no type>,
String: [[FILEPATHVAL:.+[\\/]debug-info-codeview-buildinfo.c]]
----------------
aganea wrote:
> amccarth wrote:
> > PWD? Did you mean CWD (current working directory)?
> I meant the current working directory when the program starts. I was under
> the impression that the nomenclature for that is PWD = CWD at startup. While
> CWD is the current directory at any point in time during the execution, and
> can be different of PWD.
> Would you prefer if I changed the regex capture name to CWD?
Sorry, I always misread "pwd" as "password."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80833/new/
https://reviews.llvm.org/D80833
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
