rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
I think this looks good and @zequanwu has addressed the concerns of other
reviewers. Please wait until Wednesday before pushing in case they raise other
concerns.
================
Comment at: clang/lib/Sema/SemaStmtAttr.cpp:175
+namespace {
+class CallExprFinder : public ConstEvaluatedExprVisitor<CallExprFinder> {
+ bool FoundCallExpr = false;
----------------
I guess I'm a little concerned that we have to break out CRTP and walk the
whole sub statement to make this warning work, but we do that kind of stuff
everywhere I guess. :( I wish we had a cheaper way to do this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79121/new/
https://reviews.llvm.org/D79121
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
