xazax.hun added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:90
+
+  TriState GetCmpOpState(size_t CurrentOPIndex, size_t QueriedOPIndex) const {
+    assert(CurrentOPIndex < CmpOpCount && QueriedOPIndex <= CmpOpCount);
----------------
I think this function should not work with indices. It should work with 
operators. So the caller of this function never need to invoke `IndexFromOp` or 
`OpFromIndex` making this function easier to use.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78933/new/

https://reviews.llvm.org/D78933



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to