sameerds added inline comments.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3162
+ Opts.OpenMPIsDevice && (T.isNVPTX() || T.isAMDGCN()) &&
Args.hasArg(options::OPT_fopenmp_cuda_force_full_runtime);
----------------
jdoerfert wrote:
> Can we please not call it CUDA mode for non-CUDA targets? Or do you expect
> the compilation to "identify" as CUDA compilation?
I suspect it's just a lot of water under the bridge. All over Clang, HIP has
traditionally co-opted CUDA code without introducing new identifiers, like
"-fcuda-is-device". It won't be easy to redo that now, and definitely looks out
of scope for this change. A typical HIP compilation usually does identify
itself as a HIP compilation like setting the isHIP flag. This allows the
frontend to distinguish between CUDA and HIP when it matters.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79754/new/
https://reviews.llvm.org/D79754
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
