plotfi added a comment. That was a good fix. I am pretty sure this does mean the diagnostics-order.c will fail on apple's bots. The same diagnostics lines print, but in the wrong order. I haven't root caused that yet.
In D72841#2030099 <https://reviews.llvm.org/D72841#2030099>, @mibintc wrote: > In D72841#2029821 <https://reviews.llvm.org/D72841#2029821>, @plotfi wrote: > > > @ab @rjmccall @mibintc Posted D79730 <https://reviews.llvm.org/D79730> for > > consideration. > > @mibintc can you produce a version of _this_ diff that works with D79730 > > <https://reviews.llvm.org/D79730> applied. Currently the following fail, as > > they do on Apple Master: > > > @rjmccall accepted the proposed patch https://reviews.llvm.org/D79735, so I > pushed that. I also tried your patch and the 3 CodeGen tests pass but the > diagnostics-order.c test fails > > > > > > > Failing Tests (4): > > Clang :: CodeGen/finite-math.c > > Clang :: CodeGen/fp-floatcontrol-stack.cpp > > Clang :: CodeGenOpenCL/relaxed-fpmath.cl > > Clang :: Frontend/diagnostics-order.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
