rjmccall added inline comments.

================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3185
   Opts.FiniteMathOnly = Args.hasArg(OPT_ffinite_math_only) ||
       Args.hasArg(OPT_cl_finite_math_only) ||
       Args.hasArg(OPT_cl_fast_relaxed_math);
----------------
mibintc wrote:
> @rjmccall @plotfi These earlier patches are also deriving the value of 
> LangOpts from the settings of CG opts
I don't know what you mean here; the code you're quoting just seems to be 
looking at `Args`.  It's fine to re-parse arguments in both places if that 
makes something easier.  The problem is that you're looking at the 
CodeGenOptions structure itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to