LegalizeAdulthood added a comment. In http://reviews.llvm.org/D17482#372677, @alexfh wrote:
> Sorry for leaving this without attention for a while. > > I'm somewhat concerned about this change. It's adding a certain level of > complexity, but doesn't cover some less trivial cases like handling of > multiple headers. In the context of a clang-tidy check, what would be gained by verifying changes made to multiple headers that isn't already tested by verifying changes made to a single header? > Can you take a look at existing tests and say how many times this feature is > going to be used, if it gets added to the testing script? At least two of the checks I've already added have complaints that they don't work on headers. While this change was waiting to be reviewed, another check was added that made changes to headers but had no way to verify them. http://reviews.llvm.org/D17482 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
