thakis added inline comments.
================ Comment at: clang/utils/TableGen/TableGen.cpp:196 + clEnumValN(GenArmSveCodeGenMap, "gen-arm-sve-codegenmap", + "Generate arm_sve_codegenmap.inc for clang"), clEnumValN(GenArmMveHeader, "gen-arm-mve-header", ---------------- sdesmalen wrote: > thakis wrote: > > Any reason these aren't called `-gen-arm-sve-builtin-def` and > > `-gen-arm-sve-builtin-codegen` for consistency with CDE and MVE? > Not really, I can change that. Looks like you renamed the files to be consistent (thanks!), but not the flag names. Can you make those consistent too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75470/new/ https://reviews.llvm.org/D75470 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits