balazske added a comment. Split the patch into two is really start it from "scratch" again, copy the code, decide what to go into the first or second part (and what order) (really what?), make some mess with git commands and branches and rebase, probably rebuild whole llvm, if review changes are to be done again comes the "git mess" problem (change code in a commit that belongs logically before another). It can be more work to make changes in the "old way" that are done in the second part in a new way. Or somebody could say "this thing makes no sense, I want to see the next diff how about it is used", and commit can happen really only if the next change is accepted too. So I do not prefer to split it, the change is not a very complicated one and the modifications belong somewhat together.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
