rjmccall added a comment.

Yeah, looks like returning true causes the variable to be marked as invalid 
(not unreasonable, since maybe its type is wrong), which causes downstream 
diagnostics to be suppressed.

Both test cases should probably be fixed to assign into a different variable so 
that we continue to test the diagnostic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74116/new/

https://reviews.llvm.org/D74116



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to