kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.
LGTM. You can wait for a day in case other reviewers have comments.
================
Comment at: clang/lib/Serialization/ASTWriter.cpp:6575
+template <> void ASTRecordWriter::writeUserType(OMPTraitInfo *TI) {
+ writeUInt32(TI->Sets.size());
----------------
jdoerfert wrote:
> kiranchandramohan wrote:
> > Had to also move this up in the file to avoid an instantiation after use
> > error.
> I didn't get that but I have it in the header, I'll figure it out.
You should remove the declaration of this specialization from the header file
first.
Then move this definition of the specialization up in the file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71830/new/
https://reviews.llvm.org/D71830
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
