jdoerfert marked an inline comment as done. jdoerfert added inline comments.
================ Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + ---------------- jdoerfert wrote: > kiranchandramohan wrote: > > jdoerfert wrote: > > > kiranchandramohan wrote: > > > > jdoerfert wrote: > > > > > kiranchandramohan wrote: > > > > > > Compiler throws up this error. > > > > > > error: explicit specialization in non-namespace scope ‘class > > > > > > clang::ASTRecordReader’ > > > > > Oh, my compiler was happy. Let me rebase and see what the pre-merge > > > > > bots say so I might get some insight into the problem. > > > > Were you able to reproduce the error? I was using gcc 9.2 compiler. > > > I have not seen the error yet. I build with clang. Do you happen to have > > > an idea how to refactor this? I will look into it with a new gcc asap. > > Moving the specialization to the source file seems to fix the issue. > I will do that then. Did you find the time to look over the rest? > Moving the specialization to the source file seems to fix the issue. Like this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71830/new/ https://reviews.llvm.org/D71830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits